fix: 未登录时阻止下载StarLight实例

apps/app-frontend/src/composables/skin-site-session.test.ts

@@ -3,6 +3,7 @@ import test from 'node:test'
 
 import {
 	clearHostedSession,
+	HOSTED_ACCOUNT_REQUIRED_MESSAGE,
 	hostedCreate,
 	hostedDefault,
 	hostedSync,
@@ -46,6 +47,10 @@ test('hosted installation sends the JWT to native commands while Local needs no
 	let createdId = 'instance'
 	let instanceExists = false
 	let tokenRequests = 0
+	let accounts: Array<{
+		account_type: string
+		yggdrasil?: { api_root: string }
+	}> = [{ account_type: 'microsoft' }]
 	const frame = {
 		postMessage(data: { type: string; requestId: string }) {
 			if (data.type !== 'starlight-pack-token-request') return
@@ -70,6 +75,14 @@ test('hosted installation sends the JWT to native commands while Local needs no
 			__TAURI_INTERNALS__: {
 				async invoke(command: string, args: Record<string, unknown>) {
 					calls.push({ command, args })
+					if (command === 'plugin:install|hosted_has_game_account')
+						return accounts.some(
+							(account) =>
+								account.account_type === 'microsoft' ||
+								(account.account_type === 'yggdrasil' &&
+									account.yggdrasil?.api_root.replace(/\/+$/, '') ===
+										'https://skin.starlight.cool/yggdrasil'),
+						)
 					if (command === 'plugin:install|hosted_sync' && syncResponse) return syncResponse()
 					if (command === 'plugin:instance|instance_get')
 						return instanceExists ? { id: args.instanceId } : null
@@ -99,7 +112,13 @@ test('hosted installation sends the JWT to native commands while Local needs no
 		await setInstanceMode('instance', 'starlight')
 		assert.equal(tokenRequests, 4)
 		assert.deepEqual(
-			calls.map(({ command }) => command),
+			calls
+				.map(({ command }) => command)
+				.filter(
+					(command) =>
+						command.startsWith('plugin:install|') &&
+						command !== 'plugin:install|hosted_has_game_account',
+				),
 			[
 				'hosted_set_session',
 				'hosted_default',
@@ -210,9 +229,35 @@ test('hosted installation sends the JWT to native commands while Local needs no
 		assert.equal(tokenRequests, requestsBeforeLogout)
 		const attempts: string[] = []
 		const stopListening = onHostedPackAttemptStarted((id) => attempts.push(id))
+		accounts = []
+		const installCallsBeforeAccountFailure = calls.filter(
+			({ command }) =>
+				command.startsWith('plugin:install|') &&
+				command !== 'plugin:install|hosted_has_game_account',
+		).length
+		await assert.rejects(hostedSync('failed-instance'), {
+			message: HOSTED_ACCOUNT_REQUIRED_MESSAGE,
+		})
+		await assert.rejects(hostedCreate(), {
+			message: HOSTED_ACCOUNT_REQUIRED_MESSAGE,
+		})
+		assert.deepEqual(attempts, [])
+		assert.equal(
+			calls.filter(
+				({ command }) =>
+					command.startsWith('plugin:install|') &&
+					command !== 'plugin:install|hosted_has_game_account',
+			).length,
+			installCallsBeforeAccountFailure,
+		)
+		const unauthenticatedCreation = useHostedCreation()
+		await unauthenticatedCreation.install()
+		assert.equal(unauthenticatedCreation.installError.value, HOSTED_ACCOUNT_REQUIRED_MESSAGE)
+		assert.equal(unauthenticatedCreation.createdInstance.value, undefined)
+		accounts = [{ account_type: 'microsoft' }]
 		const unauthenticatedRetry = hostedSync('failed-instance')
-		assert.deepEqual(attempts, ['failed-instance'])
 		await assert.rejects(unauthenticatedRetry)
+		assert.deepEqual(attempts, ['failed-instance'])
 		stopListening()
 		await assert.rejects(hostedSync('failed-instance'))
 		assert.equal(attempts.length, 1)

apps/app-frontend/src/composables/useHostedCreation.ts

@@ -10,6 +10,10 @@ const createdInstance = ref<string>()
 const completed = ref(false)
 let generation = 0
 
+function errorMessage(cause: unknown) {
+	return cause instanceof Error ? cause.message : String(cause)
+}
+
 export function forgetHostedCreation(instanceId: string) {
 	if (createdInstance.value !== instanceId) return
 	generation++
@@ -27,7 +31,7 @@ export function markHostedCreationCompleted(instanceId: string) {
 export function markHostedCreationFailed(instanceId: string, cause: unknown) {
 	if (createdInstance.value !== instanceId) return
 	completed.value = false
-	installError.value = String(cause)
+	installError.value = errorMessage(cause)
 }
 
 export function useHostedCreation() {
@@ -63,7 +67,7 @@ export function useHostedCreation() {
 		} catch (cause) {
 			if (attempt === generation) {
 				if (createdInstance.value) markHostedCreationFailed(createdInstance.value, cause)
-				else installError.value = String(cause)
+				else installError.value = errorMessage(cause)
 			}
 		} finally {
 			installing.value = false

apps/app-frontend/src/helpers/hosted-packs.ts

@@ -7,6 +7,8 @@ import {
 	waitForSkinSiteSession,
 } from '../composables/skin-site-session.ts'
 
+export const HOSTED_ACCOUNT_REQUIRED_MESSAGE = '您需要登录正版或皮肤站账号后才能操作'
+
 let sessionUpdate: Promise<void> = Promise.resolve()
 const attemptListeners = new Set<(instanceId: string) => void>()
 
@@ -21,6 +23,13 @@ function startHostedPackAttempt(instanceId: string) {
 	for (const listener of attemptListeners) listener(instanceId)
 }
 
+export async function requireHostedGameAccount(): Promise<void> {
+	const available = await invokeHosted<boolean>('plugin:install|hosted_has_game_account')
+	if (!available) {
+		throw new Error(HOSTED_ACCOUNT_REQUIRED_MESSAGE)
+	}
+}
+
 export function clearHostedSession(): Promise<void> {
 	const update = sessionUpdate
 		.catch(() => {})
@@ -100,13 +109,16 @@ export interface HostedSyncResult {
 }
 export const hostedDefault = () =>
 	invokeWithSession<HostedPublication>('plugin:install|hosted_default')
-export const hostedCreate = (gameDirRoot?: string | null) =>
-	invokeWithSession<string>('plugin:install|hosted_create', {
+export const hostedCreate = async (gameDirRoot?: string | null) => {
+	await requireHostedGameAccount()
+	return invokeWithSession<string>('plugin:install|hosted_create', {
 		gameDirRoot: gameDirRoot ?? null,
 	})
+}
 export const hostedBinding = (instanceId: string) =>
 	invokeHosted<HostedBinding | null>('plugin:install|hosted_binding', { instanceId })
-export const hostedSync = (instanceId: string) => {
+export const hostedSync = async (instanceId: string) => {
+	await requireHostedGameAccount()
 	startHostedPackAttempt(instanceId)
 	return invokeWithSession<HostedSyncResult>('plugin:install|hosted_sync', { instanceId })
 }