refactor: remove telemetry and fix launcher workflows

apps/app-frontend/src/components/ui/settings/DownloadJavaModal.vue

@@ -21,7 +21,6 @@ import JetBrainsLogo from '@/assets/java-vendors/jetbrains.png'
 import MicrosoftLogo from '@/assets/java-vendors/microsoft.png'
 import OracleLogo from '@/assets/java-vendors/oracle.png'
 import SapLogo from '@/assets/java-vendors/sap.png'
-import { trackEvent } from '@/helpers/analytics'
 import { download_java, list_java_feed_vendors, list_java_feed_versions } from '@/helpers/jre'
 
 const { handleError } = injectNotificationManager()
@@ -117,7 +116,6 @@ function backToVendors() {
 
 async function downloadVersion(info) {
 	downloading.value = info.major_version
-	trackEvent('JavaDownload', { vendor: info.vendor, version: info.major_version })
 	modal.value?.hide()
 
 	const job = await download_java(info.vendor, info.major_version).catch(handleError)

apps/app-frontend/src/components/ui/settings/FeatureFlagSettings.vue

@@ -23,7 +23,6 @@ const { formatMessage } = useVIntl()
 const { addNotification } = injectNotificationManager()
 const isDevEnvironment = await isDev()
 const previewMinecraftCrashModal = inject<() => void>('previewMinecraftCrashModal')
-const previewPrivacyConsentModal = inject<() => Promise<void>>('previewPrivacyConsentModal')
 const messages = defineMessages({
 	resetToDefault: {
 		id: 'app.settings.feature-flags.reset-to-default',
@@ -53,10 +52,6 @@ const messages = defineMessages({
 		id: 'app.settings.about.preview-minecraft-crash-modal',
 		defaultMessage: 'Preview Minecraft crash window',
 	},
-	previewPrivacyConsentModal: {
-		id: 'app.settings.about.preview-privacy-consent-modal',
-		defaultMessage: 'Preview privacy & security modal',
-	},
 })
 
 const settings = ref(await getSettings())
@@ -127,9 +122,6 @@ watch(
 			<Button type="base" @click="previewMinecraftCrashModal?.()">
 				<WrenchIcon /> {{ formatMessage(messages.previewMinecraftCrashModal) }}
 			</Button>
-			<Button type="base" @click="previewPrivacyConsentModal?.()">
-				<WrenchIcon /> {{ formatMessage(messages.previewPrivacyConsentModal) }}
-			</Button>
 		</div>
 	</SettingsSection>
 </template>

apps/app-frontend/src/components/ui/settings/JavaSettings.vue

@@ -19,7 +19,6 @@ import MemoryAllocationDisplay from '@/components/ui/MemoryAllocationDisplay.vue
 import DownloadJavaModal from '@/components/ui/settings/DownloadJavaModal.vue'
 import InstalledJavaModal from '@/components/ui/settings/InstalledJavaModal.vue'
 import useMemorySlider from '@/composables/useMemorySlider'
-import { trackEvent } from '@/helpers/analytics'
 import { collectGcContext } from '@/helpers/gc/context'
 import { wait_for_install_job } from '@/helpers/install'
 import { getJavaArgumentPresets } from '@/helpers/java-argument-presets'
@@ -249,7 +248,6 @@ async function runScan(exhaustive) {
 
 	scanning.value = true
 	scanMode.value = 'quick'
-	trackEvent('JavaQuickScan', { source: 'settings' })
 	try {
 		await find_filtered_jres(null, false, true, false).catch(handleError)
 	} finally {
@@ -262,7 +260,6 @@ async function confirmDeepScan() {
 	showDeepScanConfirm.value = false
 	scanning.value = true
 	scanMode.value = 'deep'
-	trackEvent('JavaDeepScan', { source: 'settings' })
 	try {
 		await find_filtered_jres(null, true, true, true).catch(handleError)
 	} finally {
@@ -280,7 +277,6 @@ async function handleManualAdd() {
 	if (!javaInfo) return
 
 	await set_java_version(javaInfo).catch(handleError)
-	trackEvent('JavaManualSelect', { path: filePath })
 }
 
 async function onJavaDownloaded(job) {

apps/app-frontend/src/components/ui/settings/PrivacySettings.vue

@@ -1,156 +0,0 @@
-<script setup lang="ts">
-import { defineMessages, injectNotificationManager, Toggle, useVIntl } from '@modrinth/ui'
-import { computed, ref } from 'vue'
-
-import { getPrivacySettings, setDiscordRpcEnabled, setTelemetryEnabled } from '@/helpers/settings'
-
-import SettingsRow from './SettingsRow.vue'
-import SettingsSaveStatus from './SettingsSaveStatus.vue'
-
-const { formatMessage } = useVIntl()
-const { handleError } = injectNotificationManager()
-const privacy = ref(await getPrivacySettings())
-const telemetrySaving = ref(false)
-const discordSaving = ref(false)
-const lastSaveState = ref<'idle' | 'saved' | 'error'>('idle')
-const retrySave = ref<(() => void) | undefined>()
-
-const messages = defineMessages({
-	telemetry: {
-		id: 'app.settings.privacy.telemetry',
-		defaultMessage: 'Allow telemetry',
-	},
-	telemetryDescription: {
-		id: 'app.settings.privacy.telemetry-description',
-		defaultMessage:
-			'Send one anonymous daily activity signal to improve usage statistics. Minecraft logs and account credentials are never uploaded.',
-	},
-	discordRpc: {
-		id: 'app.settings.privacy.discord-rpc',
-		defaultMessage: 'Discord Rich Presence',
-	},
-	discordRpcDescription: {
-		id: 'app.settings.privacy.discord-rpc-description',
-		defaultMessage: 'Show your current launcher or game activity in Discord.',
-	},
-	dataHandling: {
-		id: 'app.settings.privacy.data-handling',
-		defaultMessage:
-			'Telemetry uses a random installation identifier and sends only a daily activity signal. Turning telemetry off clears pending data immediately.',
-	},
-})
-const saveStatus = computed(() => {
-	if (telemetrySaving.value || discordSaving.value) return 'saving'
-	return lastSaveState.value
-})
-
-async function updateTelemetry(value: boolean) {
-	if (telemetrySaving.value) return
-	const previous = privacy.value.telemetry
-	privacy.value.telemetry = value
-	telemetrySaving.value = true
-	lastSaveState.value = 'idle'
-	retrySave.value = undefined
-	try {
-		const saved = await setTelemetryEnabled(value)
-		privacy.value.telemetry = saved.telemetry
-		privacy.value.consent_version = saved.consent_version
-		lastSaveState.value = 'saved'
-	} catch (error) {
-		privacy.value.telemetry = previous
-		retrySave.value = () => void updateTelemetry(value)
-		lastSaveState.value = 'error'
-		handleError(error)
-	} finally {
-		telemetrySaving.value = false
-	}
-}
-
-async function updateDiscordRpc(value: boolean) {
-	if (discordSaving.value) return
-	const previous = privacy.value.discord_rpc
-	privacy.value.discord_rpc = value
-	discordSaving.value = true
-	lastSaveState.value = 'idle'
-	retrySave.value = undefined
-	try {
-		const saved = await setDiscordRpcEnabled(value)
-		privacy.value.discord_rpc = saved.discord_rpc
-		lastSaveState.value = 'saved'
-	} catch (error) {
-		privacy.value.discord_rpc = previous
-		retrySave.value = () => void updateDiscordRpc(value)
-		lastSaveState.value = 'error'
-		handleError(error)
-	} finally {
-		discordSaving.value = false
-	}
-}
-</script>
-
-<template>
-	<div class="flex w-full flex-col gap-4">
-		<header class="settings-page-header">
-			<SettingsSaveStatus :status="saveStatus" :retry="retrySave" />
-		</header>
-		<div class="settings-page-card">
-			<SettingsRow>
-				<template #label>
-					<span id="settings-target-privacy-telemetry" tabindex="-1">
-						{{ formatMessage(messages.telemetry) }}
-					</span>
-				</template>
-				<template #description>{{ formatMessage(messages.telemetryDescription) }}</template>
-				<template #control>
-					<Toggle
-						id="privacy-telemetry"
-						:model-value="privacy.telemetry"
-						:disabled="telemetrySaving"
-						@update:model-value="(value) => updateTelemetry(!!value)"
-					/>
-				</template>
-			</SettingsRow>
-			<SettingsRow>
-				<template #label>
-					<span id="settings-target-privacy-discord-rpc" tabindex="-1">
-						{{ formatMessage(messages.discordRpc) }}
-					</span>
-				</template>
-				<template #description>{{ formatMessage(messages.discordRpcDescription) }}</template>
-				<template #control>
-					<Toggle
-						id="privacy-discord-rpc"
-						:model-value="privacy.discord_rpc"
-						:disabled="discordSaving"
-						@update:model-value="(value) => updateDiscordRpc(!!value)"
-					/>
-				</template>
-			</SettingsRow>
-		</div>
-
-		<p class="settings-page-note">{{ formatMessage(messages.dataHandling) }}</p>
-	</div>
-</template>
-
-<style scoped>
-.settings-page-card {
-	overflow: hidden;
-	border: 1px solid
-		var(--settings-card-border, color-mix(in srgb, var(--surface-4) 72%, transparent));
-	border-radius: var(--radius-md);
-	background: var(--surface-2);
-}
-
-.settings-page-header {
-	display: flex;
-	min-height: 0;
-	justify-content: flex-end;
-}
-
-.settings-page-note {
-	margin: 0;
-	color: var(--color-secondary);
-	font-size: 0.8125rem;
-	line-height: 1.5;
-}
-</style>

apps/app-frontend/src/components/ui/settings/settings-category-definitions.ts

@@ -10,7 +10,6 @@ export type SettingsCategoryId =
 	| 'content-downloads'
 	| 'network-multiplayer'
 	| 'storage-backups'
-	| 'privacy-data'
 	| 'updates'
 	| 'about'
 	| 'feature-flags'
@@ -106,15 +105,6 @@ export const settingsCategoryDefinitions: SettingsCategoryDefinition[] = [
 		group: 'data-privacy',
 		onboardingId: 'settings-tab-storage-backups',
 	},
-	{
-		id: 'privacy-data',
-		name: defineMessage({
-			id: 'app.settings.tabs.privacy-data',
-			defaultMessage: 'Privacy & data sharing',
-		}),
-		group: 'data-privacy',
-		onboardingId: 'settings-tab-privacy-data',
-	},
 	{
 		id: 'updates',
 		name: defineMessage({ id: 'app.settings.tabs.updates', defaultMessage: 'Updates' }),

apps/app-frontend/src/components/ui/settings/settings-registry.ts

@@ -72,10 +72,6 @@ const categoryContent: Record<SettingsCategoryId, Pick<SettingsCategory, 'icon'
 		icon: ArchiveIcon,
 		content: defineAsyncComponent(() => import('./StorageBackupSettings.vue')),
 	},
-	'privacy-data': {
-		icon: ShieldIcon,
-		content: defineAsyncComponent(() => import('./PrivacySettings.vue')),
-	},
 	updates: {
 		icon: RefreshCwIcon,
 		content: defineAsyncComponent(() => import('./UpdateSettings.vue')),

apps/app-frontend/src/components/ui/settings/settings-search-index.ts

@@ -221,18 +221,6 @@ export const settingsSearchEntries: SettingsSearchEntry[] = [
 		label: message('app.crash-analysis.ai.settings.title', 'Crash AI explanation'),
 		keywords: [message('app.settings.tabs.launch-defaults', 'Launch & instance defaults')],
 	},
-	{
-		id: 'privacy-telemetry',
-		categoryId: 'privacy-data',
-		targetId: 'settings-target-privacy-telemetry',
-		label: message('app.settings.privacy.telemetry', 'Telemetry'),
-	},
-	{
-		id: 'privacy-discord-rpc',
-		categoryId: 'privacy-data',
-		targetId: 'settings-target-privacy-discord-rpc',
-		label: message('app.settings.privacy.discord-rpc', 'Discord rich presence'),
-	},
 	{
 		id: 'java-installations',
 		categoryId: 'java-performance',

apps/app-frontend/src/components/ui/settings/settings-search.test.ts

@@ -28,7 +28,6 @@ const settingsComponentFiles = {
 	'content-downloads': ['./AppearanceSettings.vue', './ResourceManagementSettings.vue'],
 	'network-multiplayer': ['./ResourceManagementSettings.vue', './MultiplayerSettings.vue'],
 	'storage-backups': ['./ResourceManagementSettings.vue', './StorageSettings.vue'],
-	'privacy-data': ['./PrivacySettings.vue'],
 	updates: ['./UpdateSettings.vue'],
 	about: ['./AboutSettings.vue'],
 	'feature-flags': ['./FeatureFlagSettings.vue'],
@@ -169,7 +168,7 @@ test('developer-only settings stay out of the normal search categories', () => {
 		'content-downloads',
 		'network-multiplayer',
 	])
-	assert.deepEqual(categoriesForGroup('data-privacy'), ['storage-backups', 'privacy-data'])
+	assert.deepEqual(categoriesForGroup('data-privacy'), ['storage-backups'])
 	assert.deepEqual(categoriesForGroup('support'), ['updates', 'about'])
 	assert.deepEqual(categoriesForGroup('developer'), [])
 	assert.deepEqual(categoriesForGroup('developer', true), ['feature-flags'])