Compare commits

..
Author SHA1 Message Date
AxTps 0195cbf5ac fix: 修复 collect_crash_context 中凭据收集的类型不匹配
Sync source to CNB / Sync Git ref (push) Skipped
Credentials::get_all 返回 DashMap,直接 collect 会得到
Vec<(Uuid, Credentials)>,与 CrashContext.credentials 的
Vec<Credentials> 不符,导致编译失败。补上与 analyze_crash 一致的
.map(|credential| credential.1)。
2026-10-17 18:16:36 +08:00
AxTps ccb96a8cf1 fix: LogShare 采集改用轻量日志收集,修复崩溃日志上传失败
Sync source to CNB / Sync Git ref (push) Skipped
崩溃弹窗的 LogShare 摘要与 LogAgent 深度分析此前都会失败。原因是
logshare 的 prepare_upload 直接调用完整崩溃分析 analyze_crash,会
额外扫描 mod jar、比对 mod 快照并查询 Windows 事件,在这种大型实例
上容易出错或超时,错误被前端 uploadTicketForInstance 捕获成 null,
最终表现为无法上传/无法准备诊断。

对齐 Axolotl 的做法,新增轻量的 collect_crash_context /
collect_crash_logs,只做路径解析、候选收集、读取与脱敏,不触发
mod 扫描与快照副作用。SourceCandidate / SourceText 补充 upload_name
字段(采集时按目录加 crash-reports/ 前缀),logshare 的 prepare_upload
改调该轻量函数。
2026-10-13 22:01:02 +08:00
7 changed files with 88 additions and 104 deletions

No files matched your search

@@ -32,31 +32,6 @@ export const ANNOUNCEMENT_CHANGE_TYPES: readonly AnnouncementChangeType[] = [
] ]
export const launcherAnnouncements: readonly LauncherAnnouncement[] = [ export const launcherAnnouncements: readonly LauncherAnnouncement[] = [
{
id: 'launcher-1.0.2-beta7',
version: '1.0.2-beta7',
publishedAt: '2026-10-17',
title: {
'en-US': 'Starlight Launcher 1.0.2-beta7',
'zh-CN': 'Starlight Launcher 1.0.2-beta7',
},
changes: {
fixed: [
{
'en-US': 'Fixed real-time log backlog that could stall the console under heavy output.',
'zh-CN': '修复实时日志积压导致控制台卡顿的问题。',
},
{
'en-US': 'The update channel now defaults to the build type: installing a Beta build starts on the Beta channel instead of Release.',
'zh-CN': '更新通道默认值改为跟随安装包版本:安装 Beta 版后默认使用 Beta 通道,不再回落为 Release。',
},
{
'en-US': 'On Linux, the default game directory for StarLight instances no longer points at the system install path (e.g. /usr/bin); it falls back to the home directory.',
'zh-CN': 'Linux 上 StarLight 实例的默认游戏目录不再指向系统安装路径(如 /usr/bin),改为回退到用户主目录。',
},
],
},
},
{ {
id: 'launcher-1.0.2-beta6', id: 'launcher-1.0.2-beta6',
version: '1.0.2-beta6', version: '1.0.2-beta6',
+6 -3
View File
@@ -324,9 +324,12 @@ async fn initialize_state(app: tauri::AppHandle) -> api::Result<()> {
/// external game-directory root for the one-click StarLight install flow. /// external game-directory root for the one-click StarLight install flow.
#[tauri::command] #[tauri::command]
fn get_launcher_root_dir() -> api::Result<String> { fn get_launcher_root_dir() -> api::Result<String> {
let dir = theseus::default_game_dir_root().ok_or_else(|| { let exe = std::env::current_exe().map_err(|error| {
theseus::Error::from(theseus::ErrorKind::FSError(error.to_string()))
})?;
let dir = exe.parent().ok_or_else(|| {
theseus::Error::from(theseus::ErrorKind::FSError( theseus::Error::from(theseus::ErrorKind::FSError(
"Could not determine a default game directory root".to_string(), "Launcher executable has no parent directory".to_string(),
)) ))
})?; })?;
Ok(dir.to_string_lossy().into_owned()) Ok(dir.to_string_lossy().into_owned())
@@ -336,7 +339,7 @@ fn get_launcher_root_dir() -> api::Result<String> {
fn get_update_channel(app: tauri::AppHandle) -> api::Result<String> { fn get_update_channel(app: tauri::AppHandle) -> api::Result<String> {
let channel = read_update_channel_state(&app)? let channel = read_update_channel_state(&app)?
.active_channel .active_channel
.unwrap_or_else(|| theseus::default_update_channel().to_string()); .unwrap_or_else(|| "release".to_string());
match channel.as_str() { match channel.as_str() {
"release" | "beta" => Ok(channel), "release" | "beta" => Ok(channel),
@@ -109,6 +109,7 @@ pub struct CrashAnalysisMod {
struct SourceCandidate { struct SourceCandidate {
path: PathBuf, path: PathBuf,
filename: String, filename: String,
upload_name: String,
source_type: &'static str, source_type: &'static str,
modified: SystemTime, modified: SystemTime,
} }
@@ -116,10 +117,25 @@ struct SourceCandidate {
#[derive(Debug)] #[derive(Debug)]
struct SourceText { struct SourceText {
filename: String, filename: String,
upload_name: String,
source_type: &'static str, source_type: &'static str,
modified: SystemTime, modified: SystemTime,
content: String, content: String,
} }
pub(super) struct CollectedCrashLog {
pub name: String,
pub content: CensoredString,
}
pub(super) struct CollectedCrashLogs {
pub combined_log: CensoredString,
pub sources: Vec<CollectedCrashLog>,
}
struct CrashContext {
sources: Vec<SourceText>,
credentials: Vec<Credentials>,
}
struct Rule { struct Rule {
id: &'static str, id: &'static str,
@@ -1185,20 +1201,25 @@ async fn collect_candidates(
) -> crate::Result<Vec<SourceCandidate>> { ) -> crate::Result<Vec<SourceCandidate>> {
let mut candidates = Vec::new(); let mut candidates = Vec::new();
let mut locations = vec![ let mut locations = vec![
(directories.game_logs_dir(instance_root), "minecraft_log"), (
directories.game_logs_dir(instance_root),
"minecraft_log",
None,
),
( (
directories.game_crash_reports_dir(instance_root), directories.game_crash_reports_dir(instance_root),
"crash_report", "crash_report",
Some("crash-reports"),
), ),
(instance_root.to_path_buf(), "instance_log"), (instance_root.to_path_buf(), "instance_log", None),
]; ];
if let Some(dot_minecraft) = isolated_minecraft_root(instance_root) { if let Some(dot_minecraft) = isolated_minecraft_root(instance_root) {
// PCL-CE also searches the shared `.minecraft` root for JVM crash // PCL-CE also searches the shared `.minecraft` root for JVM crash
// logs when a version-isolated instance is active. // logs when a version-isolated instance is active.
locations.push((dot_minecraft, "minecraft_root_log")); locations.push((dot_minecraft, "minecraft_root_log", None));
} }
for (directory, default_type) in locations { for (directory, default_type, upload_prefix) in locations {
if !tokio::fs::try_exists(&directory).await? { if !tokio::fs::try_exists(&directory).await? {
continue; continue;
} }
@@ -1248,6 +1269,9 @@ async fn collect_candidates(
}; };
candidates.push(SourceCandidate { candidates.push(SourceCandidate {
path: entry.path(), path: entry.path(),
upload_name: upload_prefix
.map(|prefix| format!("{prefix}/{filename}"))
.unwrap_or_else(|| filename.clone()),
filename, filename,
source_type, source_type,
modified: metadata.modified().unwrap_or(SystemTime::UNIX_EPOCH), modified: metadata.modified().unwrap_or(SystemTime::UNIX_EPOCH),
@@ -1257,6 +1281,53 @@ async fn collect_candidates(
Ok(candidates) Ok(candidates)
} }
async fn collect_crash_context(
instance_id: &str,
) -> crate::Result<CrashContext> {
let state = State::get().await?;
let (instance_path, game_dir_override) =
resolve_instance_path(instance_id, &state).await?;
let instance_root = state
.directories
.resolve_game_dir(&instance_path, game_dir_override.as_deref());
let candidates =
collect_candidates(&instance_root, &state.directories).await?;
let selected = select_run_candidates(candidates);
let sources = read_sources(selected).await;
let credentials = Credentials::get_all(&state.pool)
.await?
.into_iter()
.map(|credential| credential.1)
.collect::<Vec<_>>();
Ok(CrashContext {
sources,
credentials,
})
}
pub(super) async fn collect_crash_logs(
instance_id: &str,
) -> crate::Result<CollectedCrashLogs> {
let CrashContext {
sources,
credentials,
..
} = collect_crash_context(instance_id).await?;
let combined_log =
CensoredString::censor(build_combined_log(&sources), &credentials);
let sources = sources
.into_iter()
.map(|source| CollectedCrashLog {
name: source.upload_name,
content: CensoredString::censor(source.content, &credentials),
})
.collect();
Ok(CollectedCrashLogs {
combined_log,
sources,
})
}
fn isolated_minecraft_root(instance_root: &Path) -> Option<PathBuf> { fn isolated_minecraft_root(instance_root: &Path) -> Option<PathBuf> {
let versions_dir = instance_root.parent()?; let versions_dir = instance_root.parent()?;
if versions_dir if versions_dir
@@ -1320,6 +1391,7 @@ async fn read_sources(candidates: Vec<SourceCandidate>) -> Vec<SourceText> {
}; };
sources.push(SourceText { sources.push(SourceText {
filename: candidate.filename, filename: candidate.filename,
upload_name: candidate.upload_name,
source_type: candidate.source_type, source_type: candidate.source_type,
modified: candidate.modified, modified: candidate.modified,
content: String::from_utf8_lossy(bytes).into_owned(), content: String::from_utf8_lossy(bytes).into_owned(),
@@ -1779,6 +1851,7 @@ mod tests {
fn source(filename: &str, content: &str) -> SourceText { fn source(filename: &str, content: &str) -> SourceText {
SourceText { SourceText {
filename: filename.to_string(), filename: filename.to_string(),
upload_name: filename.to_string(),
source_type: "minecraft_log", source_type: "minecraft_log",
modified: SystemTime::now(), modified: SystemTime::now(),
content: content.to_string(), content: content.to_string(),
@@ -1802,6 +1875,7 @@ mod tests {
let candidates = vec![SourceCandidate { let candidates = vec![SourceCandidate {
path: PathBuf::from("launcher_log.txt"), path: PathBuf::from("launcher_log.txt"),
filename: "launcher_log.txt".to_string(), filename: "launcher_log.txt".to_string(),
upload_name: "launcher_log.txt".to_string(),
source_type: "minecraft_log", source_type: "minecraft_log",
modified: SystemTime::now() - Duration::from_secs(181), modified: SystemTime::now() - Duration::from_secs(181),
}]; }];
+1 -28
View File
@@ -4,8 +4,7 @@ use futures::StreamExt;
use serde::{Deserialize, Serialize}; use serde::{Deserialize, Serialize};
use serde_json::{Value, json}; use serde_json::{Value, json};
use super::CensoredString; use super::crash_analysis::collect_crash_logs;
use super::crash_analysis::analyze_crash;
use crate::State; use crate::State;
use crate::emit_logshare_ai_event; use crate::emit_logshare_ai_event;
@@ -200,32 +199,6 @@ fn source_identifier() -> String {
format!("{LOGSHARE_SOURCE_PREFIX}/{}", env!("CARGO_PKG_VERSION")) format!("{LOGSHARE_SOURCE_PREFIX}/{}", env!("CARGO_PKG_VERSION"))
} }
struct CollectedCrashLog {
name: String,
content: CensoredString,
}
struct CollectedCrashLogs {
combined_log: CensoredString,
sources: Vec<CollectedCrashLog>,
}
async fn collect_crash_logs(
instance_id: &str,
) -> crate::Result<CollectedCrashLogs> {
let analysis = analyze_crash(instance_id).await?;
Ok(CollectedCrashLogs {
combined_log: analysis.combined_log,
sources: analysis
.sources
.into_iter()
.map(|source| CollectedCrashLog {
name: source.filename,
content: source.content,
})
.collect(),
})
}
async fn prepare_upload(instance_id: &str) -> crate::Result<UploadBody> { async fn prepare_upload(instance_id: &str) -> crate::Result<UploadBody> {
let settings = get_log_share_settings().await?; let settings = get_log_share_settings().await?;
let logs = collect_crash_logs(instance_id).await?; let logs = collect_crash_logs(instance_id).await?;
+2 -2
View File
@@ -33,13 +33,13 @@ pub use logger::start_logger;
pub use state::db::{ pub use state::db::{
backup_current_app_db_for_update, beta_database_exists, backup_current_app_db_for_update, beta_database_exists,
copy_database_between_channels, copy_release_database_to_beta, copy_database_between_channels, copy_release_database_to_beta,
current_app_database_path, default_update_channel, current_app_database_path,
}; };
pub use state::{DirectoryInfo, State}; pub use state::{DirectoryInfo, State};
pub use storage::*; pub use storage::*;
pub use util::fetch::build_proxied_client; pub use util::fetch::build_proxied_client;
pub use util::file_lock::{LockingProcess, get_locking_processes}; pub use util::file_lock::{LockingProcess, get_locking_processes};
pub use util::platform::{default_game_dir_root, is_process_elevated}; pub use util::platform::is_process_elevated;
pub use util::proxy::{ProxyConfig, ProxyMode, ProxyTestResult}; pub use util::proxy::{ProxyConfig, ProxyMode, ProxyTestResult};
pub use util::symlink::SymlinkCapability; pub use util::symlink::SymlinkCapability;
+1 -13
View File
@@ -304,18 +304,6 @@ async fn app_db_path(settings_dir: &Path) -> crate::Result<PathBuf> {
Ok(settings_dir.join(channel).join(LEGACY_APP_DB_FILE)) Ok(settings_dir.join(channel).join(LEGACY_APP_DB_FILE))
} }
/// The update channel a fresh install should default to. Beta builds carry a
/// pre-release version (e.g. `1.0.2-beta7`), so their installers should start
/// on the Beta channel instead of silently falling back to Release.
pub fn default_update_channel() -> &'static str {
let version = env!("CARGO_PKG_VERSION");
if version.contains('-') {
"beta"
} else {
"release"
}
}
async fn read_update_channel( async fn read_update_channel(
settings_dir: &Path, settings_dir: &Path,
) -> crate::Result<&'static str> { ) -> crate::Result<&'static str> {
@@ -323,7 +311,7 @@ async fn read_update_channel(
let contents = match tokio::fs::read_to_string(&path).await { let contents = match tokio::fs::read_to_string(&path).await {
Ok(contents) => contents, Ok(contents) => contents,
Err(error) if error.kind() == std::io::ErrorKind::NotFound => { Err(error) if error.kind() == std::io::ErrorKind::NotFound => {
return Ok(default_update_channel()); return Ok("release");
} }
Err(error) => return Err(error.into()), Err(error) => return Err(error.into()),
}; };
-29
View File
@@ -1,6 +1,5 @@
//! Platform-related code //! Platform-related code
use daedalus::minecraft::{Os, OsRule}; use daedalus::minecraft::{Os, OsRule};
use std::path::PathBuf;
/// (e.g. "Run as administrator" on Windows). /// (e.g. "Run as administrator" on Windows).
#[cfg(target_os = "windows")] #[cfg(target_os = "windows")]
@@ -144,31 +143,3 @@ pub fn classpath_separator(java_arch: &str) -> &'static str {
Os::Windows | Os::WindowsArm64 => ";", Os::Windows | Os::WindowsArm64 => ";",
} }
} }
/// Root directory used as the default for one-click StarLight instance
/// installs. Portable builds live next to their executable, which is a fine
/// place for game data. System installs (e.g. a Linux `.deb` under `/usr/bin`)
/// do not, so fall back to the user's home directory there.
pub fn default_game_dir_root() -> Option<PathBuf> {
let exe_dir = std::env::current_exe().ok()?.parent()?.to_path_buf();
if cfg!(target_os = "linux") && is_system_install_dir(&exe_dir) {
return dirs::home_dir();
}
Some(exe_dir)
}
#[cfg(target_os = "linux")]
fn is_system_install_dir(path: &std::path::Path) -> bool {
const SYSTEM_PREFIXES: &[&str] = &[
"/usr/", "/opt/", "/snap/", "/bin/", "/sbin/", "/lib/", "/lib64/",
];
let display = path.to_string_lossy();
SYSTEM_PREFIXES
.iter()
.any(|prefix| display.starts_with(prefix))
}
#[cfg(not(target_os = "linux"))]
fn is_system_install_dir(_path: &std::path::Path) -> bool {
false
}